From 927f3eba4140be1526d51af9ecfc88b72b57dee2 Mon Sep 17 00:00:00 2001 From: pommicket Date: Tue, 20 Dec 2022 12:27:59 -0500 Subject: fix potential memory bug --- buffer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/buffer.c b/buffer.c index 6e7ba7e..bf8047c 100644 --- a/buffer.c +++ b/buffer.c @@ -1388,7 +1388,8 @@ BufferPos buffer_insert_text_at_pos(TextBuffer *buffer, BufferPos pos, String32 // create a copy of str. we need to do this to remove carriage returns and newlines in the case of line buffers char32_t str_copy[256]; - if (str.len > arr_count(str_copy)) { + bool str_is_allocated = str.len > arr_count(str_copy); + if (str_is_allocated) { char32_t *new_str = buffer_calloc(buffer, str.len, sizeof *new_str); memcpy(new_str, str.str, str.len * sizeof *str.str); str.str = new_str; @@ -1484,9 +1485,8 @@ BufferPos buffer_insert_text_at_pos(TextBuffer *buffer, BufferPos pos, String32 buffer_lines_modified(buffer, pos.line, line_idx); BufferPos b = {.line = line_idx, .index = index}; - if (str.len > arr_count(str_copy)) { + if (str_is_allocated) free(str.str); - } return b; } -- cgit v1.2.3