summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorpommicket <pommicket@gmail.com>2022-12-27 13:16:45 -0500
committerpommicket <pommicket@gmail.com>2022-12-27 13:16:45 -0500
commitcb3f9f672343a98ab8bae0479a7c2e7570c37609 (patch)
treef9b5f01b05091c88abb1c6a30b6020afd169cb12
parent1379bfc2bfc8f96215d9187e72ac30dc5c94225f (diff)
ignore telemetry/event
-rw-r--r--lsp-parse.c2
-rw-r--r--main.c6
2 files changed, 4 insertions, 4 deletions
diff --git a/lsp-parse.c b/lsp-parse.c
index 8797edf..979569e 100644
--- a/lsp-parse.c
+++ b/lsp-parse.c
@@ -341,7 +341,7 @@ static bool parse_server2client_request(LSP *lsp, JSON *json, LSPRequest *reques
}
lsp_send_response(lsp, &response);
return false;
- } else if (str_has_prefix(method, "$/")) {
+ } else if (str_has_prefix(method, "$/") || str_has_prefix(method, "telemetry/")) {
// we can safely ignore this
} else {
lsp_set_error(lsp, "Unrecognized request method: %s", method);
diff --git a/main.c b/main.c
index a0abf0a..492bc8c 100644
--- a/main.c
+++ b/main.c
@@ -1,15 +1,14 @@
/*
@TODO:
-- ignore telemetry/event
+- handle window/showMessageRequest
- https://github.com/typescript-language-server/typescript-language-server
- NOTE: This supports javascript.
- We should also add a typescript language (but just use javascript syntax highlighting for now)
- (don't want to add .ts as a Javascript extension since that won't be forwards-compatible
if we ever do add real typescript highlighting support)
-- handle window/showMessageRequest
- make sure "save as" works
-- what's wrong with gopls?
- more LSP stuff:
+ - signature help
- hover
- go to definition using LSP
- find usages
@@ -21,6 +20,7 @@
- what to do if initialize request takes a long time?
- delete old sent requests? but make sure requests that just take a long time are okay.
(if the server never sends a response)
+- what's wrong with gopls?
- TESTING: make rust-analyzer-slow (waits 10s before sending response)
- run everything through valgrind ideally with leak checking
- grep -i -n TODO *.[ch]