From 3b9e9b6df1d124b29bfd3715b6cb12cdee18b2ea Mon Sep 17 00:00:00 2001 From: John Fultz Date: Mon, 17 Jul 2023 15:49:09 -0500 Subject: Fix up std:: namespace hygiene. * Remove all uses of `using namespace std` from header files (although a few specific cases of things like `using std::vector` remain) * Move all existing uses of `using namespace std` in cpp files to after the header includes * Make coordinating changes so it builds again. Qt6 builds on Windows were breaking because of namespace collision between std::byte and some version of `byte` in one of Qt's namespaces. That breakage is now fixed. It would be good to systematically clean up all `using` declarations in header files to ensure nothing is leaking out, but that's for another time. --- quacker/lister.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'quacker/lister.cpp') diff --git a/quacker/lister.cpp b/quacker/lister.cpp index 644dd90..4cfc03e 100644 --- a/quacker/lister.cpp +++ b/quacker/lister.cpp @@ -17,7 +17,6 @@ */ #include -using namespace std; #include @@ -27,6 +26,8 @@ using namespace std; #include "lister.h" #include "customqsettings.h" +using namespace std; + ListerDialog::ListerDialog(QWidget *parent, const QString &settingsGroup, const QString &appName, int flags) : QDialog(parent), m_settingsGroup(settingsGroup), m_appName(appName), m_flags(flags) { -- cgit v1.2.3