From 3b9e9b6df1d124b29bfd3715b6cb12cdee18b2ea Mon Sep 17 00:00:00 2001 From: John Fultz Date: Mon, 17 Jul 2023 15:49:09 -0500 Subject: Fix up std:: namespace hygiene. * Remove all uses of `using namespace std` from header files (although a few specific cases of things like `using std::vector` remain) * Move all existing uses of `using namespace std` in cpp files to after the header includes * Make coordinating changes so it builds again. Qt6 builds on Windows were breaking because of namespace collision between std::byte and some version of `byte` in one of Qt's namespaces. That breakage is now fixed. It would be good to systematically clean up all `using` declarations in header files to ensure nothing is leaking out, but that's for another time. --- move.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'move.h') diff --git a/move.h b/move.h index 7a66945..1734197 100644 --- a/move.h +++ b/move.h @@ -23,8 +23,6 @@ #include "alphabetparameters.h" -using namespace std; - namespace Quackle { @@ -136,7 +134,7 @@ private: // comparison based on action, then tiles, then horizontalness, then startrow, then endcol bool operator<(const Quackle::Move &move1, const Quackle::Move &move2); -class MoveList : public vector +class MoveList : public std::vector { public: enum SortType { Equity, Score, Alphabetical, Win}; -- cgit v1.2.3