From 3938bd82ac4ac35916c83b378776159952f744eb Mon Sep 17 00:00:00 2001 From: John Fultz Date: Mon, 14 Jan 2019 01:40:11 -0600 Subject: Fix infinite loop if you give all players the same name. --- quacker/quacker.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/quacker/quacker.cpp b/quacker/quacker.cpp index 5967de8..275003f 100644 --- a/quacker/quacker.cpp +++ b/quacker/quacker.cpp @@ -653,6 +653,11 @@ void TopLevel::initializeGame(const Quackle::PlayerList &players) { random_shuffle(newPlayers.begin(), newPlayers.end()); m_firstPlayerName = newPlayers.front().name(); + if (all_of(newPlayers.begin(), + newPlayers.end(), + [&](const Quackle::Player& p) { return p.name() == prevFirst; } + )) + break; // all player names are identical...break an infinite loop } } -- cgit v1.2.3