summaryrefslogtreecommitdiff
path: root/quacker/history.cpp
diff options
context:
space:
mode:
authorJohn Fultz <jfultz@wolfram.com>2023-07-18 00:44:06 -0500
committerJohn Fultz <jfultz@wolfram.com>2023-07-18 00:44:06 -0500
commit53f394839396edd537785fc40db3090839dd7c04 (patch)
tree4198dc35fd903fbd537d798a5de06afb2e7b3253 /quacker/history.cpp
parenta68140dfb546b8a89c48bfe99d7b56d9c2908569 (diff)
Fix Qt6 MOC compilation on some platforms.
That was super painful. It seems that some of the Quackle types that have custom operator==() give fits to the MOC compiler when those types are used as arguments for slots and/or signals (or maybe it's only when they're connected in a certain way...frankly, I never did figure this out precisely to my satisfaction). The compilers provide very little help in resolving this problem. Once I understood the problem, VS22 was giving me just the tiniest morsel, enough that I could hunt down the offending slot/signal (it wasn't even giving me the name of the slot/signal...just the type it was trying to use). I've changed all offending functions to use const pointers to types instead of const references, and this makes Qt happy. I couldn't find any info on the web directly about this, but here's the closest I did find, which suggests that this is related to increased functionality in Qt6 regarding reflection. https://forum.qt.io/topic/141434/ This fixes my VC++22 x86-64 build. Hopefully it fixes all of the others, too.
Diffstat (limited to 'quacker/history.cpp')
-rw-r--r--quacker/history.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/quacker/history.cpp b/quacker/history.cpp
index 30a5361..c391d61 100644
--- a/quacker/history.cpp
+++ b/quacker/history.cpp
@@ -148,7 +148,7 @@ void History::itemActivated(QTableWidgetItem *item)
{
if (it.value() == item)
{
- emit goToHistoryLocation(it.key());
+ emit goToHistoryLocation(&it.key());
break;
}
}